[native] Add spoiler to pressableMarkdownTypes
ClosedPublic
Actions

Authored by rohan on Nov 30 2022, 2:01 PM.

Details

Reviewers

ashoat
atul
ginsu

Commits

rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes

Summary

Following the stack from @ashoat, we now add spoiler to the pressableMarkdownTypes set.

Depends on D5539

Test Plan

Check spoilers on both Android and iOS, will attach a video below.

Diff Detail

Repository

rCOMM Comm

Branch

spoiler (branched from rohan/native-spoilers)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 30 2022, 2:01 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 30 2022, 2:01 PM

rohan edited the summary of this revision. (Show Details)Nov 30 2022, 2:02 PM

rohan edited the test plan for this revision. (Show Details)

rohan edited the summary of this revision. (Show Details)

rohan added a parent revision: D5539: [native] Maintain the revealed state of spoilers.

rohan attached a referenced file: F267394: Screen Recording 2022-11-30 at 4.58.53 PM.mov. (Show Details)

Harbormaster completed remote builds in B13898: Diff 19043.Nov 30 2022, 2:13 PM

rohan requested review of this revision.Nov 30 2022, 2:13 PM

ashoat accepted this revision.Nov 30 2022, 2:16 PM

This revision is now accepted and ready to land.Nov 30 2022, 2:16 PM

Closed by commit rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes (authored by rohan). · Explain WhyNov 30 2022, 3:49 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes.

Revision Contents
Changeset List

Path

Size

native/

chat/

text-message-markdown-context.js

2 lines

Diff 19043

View Options

native/chat/text-message-markdown-context.js

[native] Add spoiler to pressableMarkdownTypesClosedPublicActions