Updated to ESM + Flow, delete all the parts we don't need (we don't need Windows, we don't need Node 10, etc.)

Can we do 0.0.1 for consistency

Set "type": "module",, then I don't think you'll .mjs... .js will default to .mjs instead of defaulting to .cjs

done

done

removed

yeah there were like 7 places where the version was set so i wanted to keep them in sync but i cleaned up most of them

deleted this whole directory

gitignored this

I tried cleaning it up but it was overwritten by the yarn scripts... will have to revisit this I think.

deleted this whole dir

Please undo this

Hmm, I think the production server is Linux x64, so I think we need some option for that, no?

You're probably adding Linux arm64 since perhaps Docker on macOS runs on that arch if the host has an Apple processor?

this is how the Docker extension for vscode formats multiline instructions, but fair, I agree that it looks worse

Oh I see. Yeah I needed Linux arm64 to run the Docker container on my machine. I'll add x64 back. I'm not sure how to test the Linux x64 build besides launching an ec2 instance and setting everything up there, which seems a little tedious. Is it possible for us to do a dry run on your server?

We don't actually use this file on buildkite (maybe @atul knows why?) but I wanted to keep it in sync with the changes I made on buildkite.com

We don't actually use this file on buildkite (maybe @atul knows why?) but I wanted to keep it in sync with the changes I made on buildkite.com

we have to copy lib.rs in or else cargo will complain

this is a symlink

the source command isn't available on the node docker image.

i was initially under the impression that this file was being used by buildkite, so was making changes here to get the CI builds to pass. when i realized we weren't actually using this file, i started making changes on buildkite directly. then i updated this file to match what we have there, in case we decide to use these files some day.

.buildkite/eslint_flow_jest.yml isn't used in Buildkite. if we were using it, the file would appear here I believe: https://buildkite.com/comm/eslint-and-flow-and-jest/steps

compare with the backup build steps, which does use our .yml: https://buildkite.com/comm/backup-build-docker/steps

This job illustrates what I'm trying to say: https://buildkite.com/comm/backup-build-docker/steps
For the "backup build (docker)" CI job, we actually use the .buildkite/backup_build.yml file in the steps. For the "ios build" CI job, we don't actually use .buildkite/ios.yml. It sounds like the plan is to eventually use .yml files for all the jobs, so I want to keep things in sync until then

ah i confused myself. we should create an empty rust library so that the yarn cleaninstall will pull in all the dependencies. then on line 142 we copy over all the source files including the actual lib.rs. after that, we build the actual library

if you have time to do the docker build tonight that would be great

the purpose of this step is build caching, so I don't want to copy in any actual source files here

https://gist.github.com/vdhanan/74abbd362960e2f5695acbb5c52383fd