[keyserver] call identity service register RPC on account creation
AbandonedPublic
Actions

Authored by varun on Jan 12 2023, 8:57 AM.

Details

Reviewers

tomek
ashoat

Summary

when an account is successfully created locally, we should send the account info to the identity service via the register RPC

Depends on D5796

Test Plan

successfully added new user info to identity service when registering a new account on keyserver

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2023, 9:00 AM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2023, 2:46 PM

rebase

varun requested review of this revision.Jan 13 2023, 12:24 PM

tomek requested changes to this revision.Jan 17 2023, 8:44 AM

tomek added inline comments.

keyserver/src/creators/account-creator.js
199–209	Are we able to successfully register the account using `placeholder`s? I guess these are needed when older clients try to register, but what would be the result of calling this function with these values?

This revision now requires changes to proceed.Jan 17 2023, 8:44 AM

You need to update registerRequestInputValidator

keyserver/src/creators/account-creator.js
200	I think this should be a `devicePublicKey`
lib/types/account-types.js
55	I think this should be a `devicePublicKey`, and we need to test setting these