Details

Reviewers

Commits

Summary

I could directly use | std::mem::take but my version also maintains initial capacity to avoid reallocatig. I consider this reasonable, as our current chunks will always be between 5-8 MiB (see https://phab.comm.dev/D5703?id=18815#inline-38279)

However, I can just use std::mem::take if requested.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

bartek held this revision as a draft.

Fix formatting

bartek published this revision for review.Dec 5 2022, 1:35 AM

Interesting! So the benefit of keeping the capacity is that we don't have to grow the vector after each chunk, right?

Seems like interesting way to go from &mut to an owned version of itself; as long we no longer need to access the chunk after we "reset" it.

I think the name could improved, all I could think of is as_new() or swap_clone() but there's probably a better name out there.

varun added inline comments.

services/blob/src/tools.rs
19 ↗	(On Diff #19126)	typo in elements

This revision is now accepted and ready to land.Dec 6 2022, 7:55 PM

Fixed typo in comment
Renamed the method to take_out() as this name is closer to similiar standard library functions (see the list). Also take_out() is distinguishable from take() which could be confused with iterator.

I was inspired by the first sentence from this doc: