Paths

Table of Contentst

-
web/modals/threads/sidebars/
-
modals/
-
threads/
-
sidebars/
-
sidebar.react.js
-
sidebars-modal.css

[web] Add unread indicator to sidebar modals
ClosedPublic
Actions

Authored by • adar on Dec 6 2022, 7:37 AM.

Details

Reviewers

atul
ginsu
rohan

Commits

rCOMM3482588d8bf6: [web] Add unread indicator to sidebar modals

Summary

This is the second part of ENG-2089. This diff adds the basic unread indicators to the sidebar modal. Changes font color and font weight of the last unread message.

Test Plan

Screenshots that show that unread thread messages appear unread in the sidebar modal in both 'All Threads' and 'My Threads' tabs.

Unread thread message	Read thread message

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• adar created this revision.Dec 6 2022, 7:37 AM

• adar held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 6 2022, 7:37 AM

• adar edited the test plan for this revision. (Show Details)Dec 6 2022, 7:40 AM

• adar added inline comments.Dec 6 2022, 7:43 AM

web/modals/threads/sidebars/sidebar.react.js
72 ↗	(On Diff #19191)	note that eslint complained when `lastActivityClassName` and `longTextEllipsisClassName` are not including in the dependency array, but since they're just strings derived from `classNames` i don't think they need to be in here see (D5697)

Harbormaster completed remote builds in B14016: Diff 19191.Dec 6 2022, 7:49 AM

• adar published this revision for review.Dec 6 2022, 8:10 AM

Should we also be styling the "new thread" in the example screenshot you posted?

web/modals/threads/sidebars/sidebar.react.js
72 ↗	(On Diff #19191)	Even though they're strings, I think `lastMessage` will still need to be recomputed if they change

This revision now requires changes to proceed.Dec 6 2022, 10:51 AM

In D5833#174057, @atul wrote:

Should we also be styling the "new thread" in the example screenshot you posted?

Can do!

make thread name appear bold as well

• adar edited the test plan for this revision. (Show Details)Dec 7 2022, 11:36 AM

Harbormaster failed remote builds in B14048: Diff 19232!Dec 7 2022, 11:45 AM

Harbormaster completed remote builds in B14048: Diff 19232.Dec 7 2022, 11:50 AM

Looks good!

(and appreciate that you updated the screenshots to match!)

This revision is now accepted and ready to land.Dec 7 2022, 12:10 PM

Closed by commit rCOMM3482588d8bf6: [web] Add unread indicator to sidebar modals (authored by • adar). · Explain WhyDec 7 2022, 12:21 PM

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMM3482588d8bf6: [web] Add unread indicator to sidebar modals.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

sidebars/

sidebar.react.js

10 lines

sidebars-modal.css

5 lines

Diff 19234

View Options

web/modals/threads/sidebars/sidebar.react.js

				use clap::{Parser, Subcommand};
	use tonic::transport::Server;			use tonic::transport::Server;

				mod keygen;
				mod opaque;
	mod service;			mod service;

				use keygen::generate_and_persist_keypair;
	use service::{IdentityServiceServer, MyIdentityService};			use service::{IdentityServiceServer, MyIdentityService};

	const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";			const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
				const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";

				#[derive(Parser)]
				#[clap(author, version, about, long_about = None)]
				#[clap(propagate_version = true)]
				struct Cli {
				#[clap(subcommand)]
				command: Commands,
				}

				#[derive(Subcommand)]
				enum Commands {
				/// Runs the server
				Server,
				/// Generates and persists a keypair to use for PAKE registration and login
				Keygen {
				#[clap(short, long)]
				#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
				dir: String,
				},
				}

	#[tokio::main]			#[tokio::main]
	async fn main() -> Result<(), Box<dyn std::error::Error>> {			async fn main() -> Result<(), Box<dyn std::error::Error>> {
				let cli = Cli::parse();
				match &cli.command {
				Commands::Keygen { dir } => {
				generate_and_persist_keypair(dir)?;
				}
				Commands::Server => {
	let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;			let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
	let identity_service = MyIdentityService::default();			let identity_service = MyIdentityService::default();

	Server::builder()			Server::builder()
	.add_service(IdentityServiceServer::new(identity_service))			.add_service(IdentityServiceServer::new(identity_service))
	.serve(addr)			.serve(addr)
	.await?;			.await?;
				}
				}

	Ok(())			Ok(())
	}			}