Page MenuHomePhabricator
Differential D5837

[services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request
ClosedPublic
Actions

Authored by • max on Dec 7 2022, 5:28 AM.
Tags
None
Referenced Files
F3254285: D5837.diff
Fri, Nov 15, 7:39 PM
Unknown Object (File)
Mon, Nov 11, 8:44 PM
Unknown Object (File)
Fri, Nov 8, 10:44 PM
Unknown Object (File)
Fri, Nov 8, 4:17 PM
Unknown Object (File)
Fri, Nov 8, 4:17 PM
Unknown Object (File)
Fri, Nov 8, 4:17 PM
Unknown Object (File)
Fri, Nov 8, 4:17 PM
Unknown Object (File)
Fri, Nov 8, 4:17 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM11eb2f8b3d66: [services/commtest] Tunnelbroker - Adding of helper function for the…
Summary

This diff introduces adding the helper method to the Commtest integration API tests with the gRPC client to call the SessionSignature request to the Tunnelbroker server and return a result from a call.
This function is called in D5931 where the tests themselves are called.

Linear task: ENG-1657

Test Plan

The commtest app is successfully built and the tests are successfully passed in the following D5931.

Diff Detail

Repository
rCOMM Comm
Branch
commtest-helpers-getsign
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Dec 7 2022, 5:28 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptDec 7 2022, 5:28 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B14031: Diff 19206.Dec 7 2022, 5:40 AM
• max added a parent revision: D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.Dec 7 2022, 5:45 AM
• max edited the summary of this revision. (Show Details)Dec 7 2022, 5:52 AM
• max added a reviewer: bartek.
• max edited the summary of this revision. (Show Details)
• max edited the summary of this revision. (Show Details)Dec 7 2022, 5:54 AM
• max removed a parent revision: D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.
• max added a child revision: D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.
• max updated this revision to Diff 19545.Dec 19 2022, 6:24 AM

Rebasing on the master changes.

• max added a parent revision: D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.Dec 19 2022, 6:25 AM
• max added a child revision: D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.Dec 19 2022, 6:32 AM
Harbormaster completed remote builds in B14306: Diff 19545.Dec 19 2022, 6:35 AM
• max removed a child revision: D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.Dec 19 2022, 6:38 AM
• max published this revision for review.Dec 19 2022, 7:03 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added 1 blocking reviewer(s): • jon.
bartek accepted this revision.Dec 20 2022, 3:04 AM
• jon accepted this revision.Dec 20 2022, 9:51 AM

LGTM

services/commtest/src/tunnelbroker/new_session.rs
16–17 ↗(On Diff #19545)

not sure which one is cleaner

This revision is now accepted and ready to land.Dec 20 2022, 9:51 AM
• max updated this revision to Diff 20160.Dec 27 2022, 4:54 AM

Make a return shorter.

• max marked an inline comment as done.Dec 27 2022, 4:55 AM
• max added inline comments.
services/commtest/src/tunnelbroker/new_session.rs
16–17 ↗(On Diff #19545)

not sure which one is cleaner

I think your edit is shorter and ok to read. I'll change it. Thanks, @jon !

Harbormaster failed remote builds in B14781: Diff 20160!Dec 27 2022, 5:07 AM
• max updated this revision to Diff 20168.Dec 27 2022, 5:25 AM
• max marked an inline comment as done.

Rebasing on master.

Harbormaster completed remote builds in B14789: Diff 20168.Dec 27 2022, 5:36 AM
Closed by commit rCOMM11eb2f8b3d66: [services/commtest] Tunnelbroker - Adding of helper function for the… (authored by • max). · Explain WhyDec 27 2022, 5:44 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM11eb2f8b3d66: [services/commtest] Tunnelbroker - Adding of helper function for the….

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
1 line
tunnelbroker/
2 lines
17 lines
4 lines

Diff 20168

View Options

services/commtest/src/lib.rs

Loading...
View Options

services/commtest/src/tunnelbroker/mod.rs

Loading...
View Options

services/commtest/src/tunnelbroker/new_session.rs

Loading...
View Options

services/commtest/src/tunnelbroker/tunnelbroker_utils.rs

Loading...