[Nix] Provide default for squadcal_url.json
ClosedPublic
Actions

Authored by • jon on Dec 8 2022, 11:43 AM.

Details

Reviewers

atul
varun
ashoat

Commits

rCOMM147886f8a769: [Nix] Provide default for squadcal_url.json

Summary

Add squalcal_url.json default with other facts.

squalcal_url.json is being used a fallback router for "/" in
this regard.

May be redundant with D5846, but aligns with intent.

https://linear.app/comm/issue/ENG-2260

Depends on D5846

Test Plan

rm keyserver/facts/*.json

nix develop

# Assert files were written, and content matches scripts/templates
ls keyserver/facts
cat keyserver/facts/*.json

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Dec 8 2022, 11:43 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2022, 11:43 AM

Harbormaster completed remote builds in B14071: Diff 19260.Dec 8 2022, 11:55 AM

• jon requested review of this revision.Dec 8 2022, 11:55 AM

Not redundant – the migration won't run when initializing a new environment

ashoat requested changes to this revision.Dec 13 2022, 9:56 AM

ashoat added inline comments.

scripts/templates/squadcal_url.json
6 ↗	(On Diff #19260)	This needs `proxy: "apache"`

This revision now requires changes to proceed.Dec 13 2022, 9:56 AM

• jon removed a parent revision: D5846: [Keyserver] Migrate to non-apache config, update native.Dec 15 2022, 9:14 AM

Address feedback

• jon marked an inline comment as done.Dec 15 2022, 9:17 AM

I would really love for the Test Plan to actually test the Apache configuration to make sure it works. Is this handled somewhere else, or are we just hoping it works, and hoping that your reviewers will catch any errors?

This revision is now accepted and ready to land.Dec 15 2022, 9:27 AM

Harbormaster completed remote builds in B14182: Diff 19400.Dec 15 2022, 9:29 AM

• jon retitled this revision from [Nix] Provide default for squalcal_url.json to [Nix] Provide default for squadcal_url.json.Dec 15 2022, 9:40 AM

Update template with settings from D5846

I would really love for the Test Plan to actually test the Apache configuration to make sure it works. Is this handled somewhere else, or are we just hoping it works, and hoping that your reviewers will catch any errors?

Tested this with the migration workflow in D5846. Just couldn't do my testing until I was able to re-create the apache workflow reliably.

The native iOS application seems to dynamically pick the changes from D5846, so this shouldn't be too much of an issue after D5846 lands.

Harbormaster completed remote builds in B14536: Diff 19793.Dec 20 2022, 10:45 AM

Closed by commit rCOMM147886f8a769: [Nix] Provide default for squadcal_url.json (authored by • jon). · Explain WhyDec 20 2022, 10:54 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM147886f8a769: [Nix] Provide default for squadcal_url.json.