[CI] Update android CI to reflect current buildkite
ClosedPublic
Actions

Authored by • jon on Dec 13 2022, 4:55 PM.

Details

Reviewers

ashoat
varun
• max

Commits

rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite

Summary

Update android CI yaml file to reflect current buildkite steps

https://linear.app/comm/issue/ENG-1079

Test Plan

Inspect https://buildkite.com/comm/android-build/steps

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Dec 13 2022, 4:55 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptDec 13 2022, 4:55 PM

Harbormaster completed remote builds in B14126: Diff 19326.Dec 13 2022, 5:08 PM

• jon requested review of this revision.Dec 13 2022, 5:08 PM

@varun understands the Rust stuff better so would love if he could take a look. Also adding @max since he's looking at Rust-on-native stuff as well

.buildkite/android.yml
2 ↗	(On Diff #19326)	Why not stick with single quotes across the whole file?

Looks good to me!

.buildkite/android.yml
7–8 ↗	(On Diff #19326)	Maybe we can merge these two?

varun accepted this revision.Dec 14 2022, 3:20 PM

This revision is now accepted and ready to land.Dec 14 2022, 3:20 PM

Address feedback

Harbormaster completed remote builds in B14153: Diff 19354.Dec 14 2022, 9:00 PM

• jon marked 2 inline comments as done.Dec 14 2022, 9:55 PM

• jon added inline comments.

.buildkite/android.yml
2 ↗	(On Diff #19326)	Was just pulling from the existing pipeline, I'll make more consistent
7–8 ↗	(On Diff #19326)	Sure

Closed by commit rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite. · Explain WhyDec 14 2022, 10:15 PM

This revision was automatically updated to reflect the committed changes.

• jon marked 2 inline comments as done.

• jon added a commit: rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite.

Revision Contents
Changeset List

Path

Size

.buildkite/

android.yml

8 lines

Diff 19357

View Options

[CI] Update android CI to reflect current buildkiteClosedPublicActions