Page MenuHomePhabricator
Differential D5863

[CI] Update android CI to reflect current buildkite
ClosedPublic
Actions

Authored by • jon on Dec 13 2022, 8:55 AM.
Tags
None
Referenced Files
F3386023: D5863.diff
Fri, Nov 29, 3:04 AM
Unknown Object (File)
Thu, Nov 14, 6:10 AM
Unknown Object (File)
Wed, Nov 13, 5:17 AM
Unknown Object (File)
Fri, Nov 8, 10:00 AM
Unknown Object (File)
Thu, Nov 7, 5:51 AM
Unknown Object (File)
Tue, Nov 5, 7:25 AM
Unknown Object (File)
Tue, Nov 5, 7:25 AM
Unknown Object (File)
Oct 27 2024, 6:27 PM
View All Files
Subscribers
atul
• max
tomek

Details

Reviewers
ashoat
varun
• max
Commits
rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite
Summary

Update android CI yaml file to reflect current buildkite steps

https://linear.app/comm/issue/ENG-1079

Test Plan

Inspect https://buildkite.com/comm/android-build/steps

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Dec 13 2022, 8:55 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptDec 13 2022, 8:55 AM
Harbormaster completed remote builds in B14126: Diff 19326.Dec 13 2022, 9:08 AM
• jon requested review of this revision.Dec 13 2022, 9:08 AM
ashoat accepted this revision.Dec 13 2022, 4:18 PM
ashoat added a reviewer: • max. ashoat added 1 blocking reviewer(s): varun.
ashoat added a subscriber: • max.

@varun understands the Rust stuff better so would love if he could take a look. Also adding @max since he's looking at Rust-on-native stuff as well

.buildkite/android.yml
2 ↗(On Diff #19326)

Why not stick with single quotes across the whole file?

• max accepted this revision.Dec 14 2022, 3:05 AM

Looks good to me!

.buildkite/android.yml
7–8 ↗(On Diff #19326)

Maybe we can merge these two?

varun accepted this revision.Dec 14 2022, 7:20 AM
This revision is now accepted and ready to land.Dec 14 2022, 7:20 AM
• jon updated this revision to Diff 19354.Dec 14 2022, 12:47 PM

Address feedback

Harbormaster completed remote builds in B14153: Diff 19354.Dec 14 2022, 1:00 PM
• jon marked 2 inline comments as done.Dec 14 2022, 1:55 PM
• jon added inline comments.
.buildkite/android.yml
2 ↗(On Diff #19326)

Was just pulling from the existing pipeline, I'll make more consistent

7–8 ↗(On Diff #19326)

Sure

Closed by commit rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite (authored by • jon). · Explain WhyDec 14 2022, 2:15 PM
This revision was automatically updated to reflect the committed changes.
• jon marked 2 inline comments as done.
• jon added a commit: rCOMMd484ff64f09d: [CI] Update android CI to reflect current buildkite.

Revision Contents
Changeset List

PathSize
.buildkite/
8 lines

Diff 19357

View Options

.buildkite/android.yml

Loading...