[native] Add a onLongPress handler in MarkdownLink
ClosedPublic
Actions

Authored by rohan on Dec 14 2022, 4:35 PM.

Details

Reviewers

ashoat
atul
ginsu

Commits

rCOMM731eea86ebf2: [native] Add a onLongPress handler in MarkdownLink

Summary

We need to add a onLongPress handler in MarkdownLink that calls the onPressMessage method from MessagePressResponderContext so you can long press links to copy them.

Linear: https://linear.app/comm/issue/ENG-2452/add-a-onlongpress-handler-in-markdownlink

Test Plan

See videos attached.

Before

After

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 14 2022, 4:35 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 14 2022, 4:35 PM

rohan edited the test plan for this revision. (Show Details)Dec 14 2022, 4:36 PM

rohan attached a referenced file: F285554: Screen Recording 2022-12-14 at 7.32.48 PM.mov. (Show Details)

rohan attached a referenced file: F285560: Screen Recording 2022-12-14 at 7.33.46 PM.mov. (Show Details)

Harbormaster completed remote builds in B14157: Diff 19361.Dec 14 2022, 4:48 PM

rohan requested review of this revision.Dec 14 2022, 4:48 PM

ashoat accepted this revision.Dec 15 2022, 7:00 AM

ashoat removed 1 blocking reviewer(s): atul.

This revision is now accepted and ready to land.Dec 15 2022, 7:00 AM

Closed by commit rCOMM731eea86ebf2: [native] Add a onLongPress handler in MarkdownLink (authored by rohan). · Explain WhyDec 15 2022, 8:09 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM731eea86ebf2: [native] Add a onLongPress handler in MarkdownLink.

rohan mentioned this in D5835: [native] Block link press if spoiler is not yet revealed.Dec 15 2022, 8:29 AM

Revision Contents
Changeset List

Path

Size

native/

markdown/

markdown-link.react.js

9 lines

Diff 19393

View Options

native/markdown/markdown-link.react.js

[native] Add a onLongPress handler in MarkdownLinkClosedPublicActions