Page MenuHomePhabricator

[native] Fix in-app notif on Android which system theme is dark
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 12:49 PM
Unknown Object (File)
Tue, Jun 11, 7:40 AM
Unknown Object (File)
May 29 2024, 9:54 PM
Unknown Object (File)
May 29 2024, 9:54 PM
Unknown Object (File)
May 25 2024, 4:40 AM
Unknown Object (File)
May 24 2024, 2:47 PM
Unknown Object (File)
May 24 2024, 11:49 AM
Unknown Object (File)
May 10 2024, 8:45 AM
Subscribers

Details

Summary

On Android, we show the same design of in-app notif for both dark mode and light mode. (Unlike iOS, where we vary it.)

However, the default text color on Android depends on the system theme. As a result, if the system theme is dark, then we end up having a white text (default) appear in front of a white background.

This diff makes sure we always set the text color explicitly instead of relying on defaults.

Test Plan

Confirm in-app notif body text can be read

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable