[native] Fix in-app notif on Android which system theme is dark
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 6:59 PM.

Details

Reviewers

marcin
tomek

Commits

rCOMMb12171abe55f: [native] Fix in-app notif on Android which system theme is dark

Summary

On Android, we show the same design of in-app notif for both dark mode and light mode. (Unlike iOS, where we vary it.)

However, the default text color on Android depends on the system theme. As a result, if the system theme is dark, then we end up having a white text (default) appear in front of a white background.

This diff makes sure we always set the text color explicitly instead of relying on defaults.

Test Plan

Confirm in-app notif body text can be read

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 17 2022, 6:59 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 6:59 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 9:16 PM

Harbormaster failed remote builds in B14221: Diff 19455!

Something is broken with iOS CI

Harbormaster completed remote builds in B14221: Diff 19455.Dec 18 2022, 2:45 PM

tomek accepted this revision.Dec 19 2022, 2:13 AM

This revision is now accepted and ready to land.Dec 19 2022, 2:13 AM

Closed by commit rCOMMb12171abe55f: [native] Fix in-app notif on Android which system theme is dark (authored by ashoat). · Explain WhyDec 19 2022, 7:30 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb12171abe55f: [native] Fix in-app notif on Android which system theme is dark.

Revision Contents
Changeset List

Path

Size

native/

push/

in-app-notif.react.js

18 lines

Diff 19573

View Options

native/push/in-app-notif.react.js

[native] Fix in-app notif on Android which system theme is darkClosedPublicActions