[lib] set min code version for message liking
ClosedPublic
Actions

Authored by ginsu on Dec 18 2022, 7:45 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMb8ff12417b3e: [lib] set min code version for message liking

Summary

set min code version for message liking to 167. Will rebase and adjust if a new build gets put out between now and landing this diff

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 18 2022, 7:45 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 18 2022, 7:45 PM

ginsu added reviewers: atul, tomek.Dec 18 2022, 7:46 PM

Harbormaster completed remote builds in B14249: Diff 19488.Dec 18 2022, 7:57 PM

ginsu requested review of this revision.Dec 18 2022, 7:57 PM

Is this the last diff to enable message liking? Did we also want to handle unliking? Or is that something we're deferring

Tentatively accepting, but let's hold off on landing until we're ready to make a release and sure about what the minimum version code will be

This revision is now accepted and ready to land.Dec 18 2022, 9:46 PM

In D5920#177125, @atul wrote:

Is this the last diff to enable message liking? Did we also want to handle unliking? Or is that something we're deferring

Yup this is the last diff in the stack, unliking should be handled by D5854, and D5961 is a follow up that handles toggling the UI text between 👍 and Unlike. Everything works so I feel that we can go ahead and still flip the switch today