[services/commtest] Tunnelbroker - Adding the tonic client builder function
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 6:42 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMM89b1b3578fcf: [services/commtest] Tunnelbroker - Adding the tonic client builder function

Summary

This diff introduces a function to build a Tonic client for further API calls in integrational tests. The pointer to the client will be passed to the helper functions (in D5931) instead of making the "global" client instance.

We are using COMM_SERVICES_PORT_TUNNELBROKER environment variable to provide a port to connect to the Tunnelbroker.
The COMM_SERVICES_HOST_TUNNELBROKER environment variable provides a host to connect to the Tunnelbroker.

Linear task: ENG-1657

Test Plan

The commtest app is successfully built and the tests are successfully passed in the following D5931 using this function results.

Diff Detail

Repository

rCOMM Comm

Branch

commtest-tonic-client-builder

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Dec 19 2022, 6:42 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 6:42 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.Dec 19 2022, 6:43 AM

• max added a child revision: D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.Dec 19 2022, 6:47 AM

Harbormaster completed remote builds in B14311: Diff 19553.Dec 19 2022, 6:51 AM

• max published this revision for review.Dec 19 2022, 7:12 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.

• max edited the summary of this revision. (Show Details)

• jon requested changes to this revision.Dec 19 2022, 12:10 PM

• jon added inline comments.

services/commtest/src/tunnelbroker/tunnelbroker_utils.rs
11 ↗	(On Diff #19553)	Should we have an expected default? e.g. `41111`. Most services will have a default tcp port.

This revision now requires changes to proceed.Dec 19 2022, 12:10 PM

• max edited the summary of this revision. (Show Details)Dec 21 2022, 6:39 AM

Fixing a port environment variable, adding default value.

• max marked an inline comment as done.Dec 21 2022, 6:42 AM

• max added inline comments.

services/commtest/src/tunnelbroker/tunnelbroker_utils.rs
11 ↗	(On Diff #19553)	Should we have an expected default? e.g. `41111`. Most services will have a default tcp port. I think it's ok to do this. I've added a default port for the service which is also in the .env file. Thanks, @jon!