Page MenuHomePhabricator
Differential D5985

[web] Remove userAgent from Redux state
ClosedPublic
Actions

Authored by ashoat on Dec 21 2022, 8:25 PM.
Tags
None
Referenced Files
F2018358: D5985.diff
Sat, Jun 15, 9:14 PM
Unknown Object (File)
Wed, Jun 12, 4:42 PM
Unknown Object (File)
Wed, Jun 12, 4:00 AM
Unknown Object (File)
Tue, Jun 11, 9:34 AM
Unknown Object (File)
Mon, Jun 10, 4:54 PM
Unknown Object (File)
Wed, Jun 5, 3:08 AM
Unknown Object (File)
Wed, Jun 5, 3:08 AM
Unknown Object (File)
Wed, Jun 5, 3:08 AM
View All Files
Subscribers
None

Details

Reviewers
ginsu
michal
atul
tomek
Commits
rCOMM80e9a6f5a7df: [web] Remove userAgent from Redux state
Summary

Same as the previous diff, basically. We should've had this in a React context... basically wanted server code to know what the user agent was while doing SSR. Now we don't do SSR, and we can just call detectBrowser() without needing to pass anything in.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 21 2022, 8:25 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 21 2022, 8:35 PM
Harbormaster failed remote builds in B14655: Diff 19991!
ashoat updated this revision to Diff 19995.Dec 21 2022, 8:41 PM

Rebase

ashoat edited the summary of this revision. (Show Details)Dec 21 2022, 8:43 PM
ashoat updated this revision to Diff 19999.Dec 21 2022, 8:49 PM

Rebase

Harbormaster completed remote builds in B14659: Diff 19995.Dec 21 2022, 8:55 PM
Harbormaster completed remote builds in B14663: Diff 19999.Dec 21 2022, 9:02 PM
ashoat requested review of this revision.Dec 21 2022, 9:03 PM
tomek accepted this revision.Dec 22 2022, 8:29 AM
tomek added inline comments.
web/chat/chat-message-list.react.js
280–287 ↗(On Diff #19999)

Can we compute this outside the component and avoid using memo?

This revision is now accepted and ready to land.Dec 22 2022, 8:29 AM
ginsu accepted this revision.Dec 22 2022, 10:17 AM
michal accepted this revision.Dec 22 2022, 10:27 AM
ashoat updated this revision to Diff 20050.Dec 22 2022, 6:31 PM

No point using props

web/chat/chat-message-list.react.js
280–287 ↗(On Diff #19999)

Good call

Harbormaster completed remote builds in B14707: Diff 20050.Dec 22 2022, 6:45 PM
Closed by commit rCOMM80e9a6f5a7df: [web] Remove userAgent from Redux state (authored by ashoat). · Explain WhyDec 22 2022, 6:58 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM80e9a6f5a7df: [web] Remove userAgent from Redux state.

Revision Contents
Changeset List

PathSize
web/
chat/
5 lines
input/
6 lines
redux/
1 line

Diff 19991

View Options

web/chat/chat-message-list.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/redux/redux-setup.js

Loading...