Paths

Table of Contentst

Differential D6008

[native] Put SIWEPanel outside of SafeAreaView
ClosedPublic
Actions

Authored by ashoat on Dec 22 2022, 4:31 PM.

Tags

None

Referenced Files

	F3516392: D6008.diff
	Sun, Dec 22, 2:16 PM

	Unknown Object (File)
	Wed, Dec 4, 11:08 AM

	Unknown Object (File)
	Wed, Dec 4, 11:08 AM

	Unknown Object (File)
	Wed, Dec 4, 11:08 AM

	Unknown Object (File)
	Wed, Dec 4, 10:49 AM

	Unknown Object (File)
	Nov 5 2024, 7:29 AM

	Unknown Object (File)
	Nov 5 2024, 7:29 AM

	Unknown Object (File)
	Nov 2 2024, 7:54 PM

Subscribers

Details

Reviewers

Commits

rCOMM500ab93fa092: [native] Put SIWEPanel outside of SafeAreaView

Summary

We want the BottomSheet to be flush with the bottom of the screen. It's cleaner that way

Test Plan

Make sure BottomSheet is flush with bottom of screen and the pill isn't in some weird white void area

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 22 2022, 4:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 22 2022, 4:31 PM

ashoat added a child revision: D6009: [native] Let the user dismiss the SIWEPanel with a gesture.Dec 22 2022, 4:32 PM

ashoat added a parent revision: D6007: [native] Wrap SIWEPanel WebView in BottomSheet.

Harbormaster completed remote builds in B14702: Diff 20044.Dec 22 2022, 4:45 PM

ashoat requested review of this revision.Dec 22 2022, 4:45 PM

atul accepted this revision.Dec 22 2022, 10:36 PM

This revision is now accepted and ready to land.Dec 22 2022, 10:36 PM

Closed by commit rCOMM500ab93fa092: [native] Put SIWEPanel outside of SafeAreaView (authored by ashoat). · Explain WhyDec 23 2022, 6:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM500ab93fa092: [native] Put SIWEPanel outside of SafeAreaView.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

10 lines

Diff 20044

native/account/logged-out-modal.react.js

Loading...