[web] Add copy-filled icon
ClosedPublic
Actions

Authored by tomek on Dec 23 2022, 8:28 AM.

Details

Reviewers

atul
kamil
ginsu

Commits

rCOMM2ce45ad9d425: [web] Add copy-filled icon

Summary

This icon is required in a design https://linear.app/comm/issue/DES-16/copy-message-button-on-web for copy button on web.

This is in hover state.

Test Plan

Display the icon next to other message actions and check if it is displayed correctly and has appropriate color even when hovering.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Dec 23 2022, 8:28 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 23 2022, 8:28 AM

In other diffs e.g. D4829 touching icons also font files were updated. It doesn't seem required here, but I might be wrong. @atul could you clarify as you created that diff?

Harbormaster completed remote builds in B14716: Diff 20069.Dec 23 2022, 8:43 AM

tomek requested review of this revision.Dec 23 2022, 8:43 AM

tomek added a child revision: D5852: Introduce message copy button on web.Dec 23 2022, 9:35 AM

In D6013#180638, @tomek wrote:

In other diffs e.g. D4829 touching icons also font files were updated. It doesn't seem required here, but I might be wrong. @atul could you clarify as you created that diff?

The font files are only relevant for native. However, since we're including the copy-filled icon in lib it'd be good to include the new font file as well so the icon can be used across platforms.

Should be able to pull the TTF from IcoMoon, let me know if you run into any issues... spent a lot of time with the icon stuff so should be able to help unblock if you run into anything.

Accepting to unblock, but would be good to include TTF in this diff to make icon available on native as well.

This revision is now accepted and ready to land.Dec 23 2022, 11:47 AM

tomek added a child revision: D6074: [web] Delete comments disabling eslint checks.Dec 28 2022, 1:17 PM

tomek removed a child revision: D6074: [web] Delete comments disabling eslint checks.

I'm going to add the icon after the whole stack is landed. Even though it should be easy, it still will take some time and has to be tested. The work will be tracked in https://linear.app/comm/issue/ENG-2579/add-copy-filled-icon-to-native-icons-font.

kamil accepted this revision.Dec 30 2022, 5:49 AM

Closed by commit rCOMM2ce45ad9d425: [web] Add copy-filled icon (authored by tomek). · Explain WhyDec 30 2022, 8:09 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2ce45ad9d425: [web] Add copy-filled icon.