[web] Prevent web Menu from dismissing itself on open
ClosedPublic
Actions

Authored by ashoat on Dec 23 2022, 10:11 AM.

Details

Reviewers

atul
ginsu
tomek
• jon

Commits

rCOMM1140d1ef8fcf: [web] Prevent web Menu from dismissing itself on open

Summary

Some change in React 18 is making document.addEventListener('click', closeMenuCallback) execute faster than before, and somehow it's able to catch the click that created it. Not sure how this is happening, but the fix is easy: stop the propagation of the click event once we handle it.

This solves https://linear.app/comm/issue/ENG-2534/cant-press-three-dots-button-in-messagelist-on-web

Test Plan

Make sure I can open the "three dots" menu in the MessageList on web

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 23 2022, 10:11 AM

ashoat published this revision for review.Dec 23 2022, 10:16 AM

Should we check if there are other instances of document.addEventListener('click' to see if there might be additional issues?

atul accepted this revision.Dec 23 2022, 10:16 AM

This revision is now accepted and ready to land.Dec 23 2022, 10:16 AM

Remaining CI builds are irrelevant to web

ginsu accepted this revision.Dec 23 2022, 10:16 AM

In D6016#180701, @atul wrote:

Should we check if there are other instances of document.addEventListener('click' to see if there might be additional issues?

Good call.

ashoat@ashoatmbp2021 [~/src/comm/web]$ git grep "'click'"
components/menu.react.js:    document.addEventListener('click', closeMenuCallback);
components/menu.react.js:      document.removeEventListener('click', closeMenuCallback);
ashoat@ashoatmbp2021 [~/src/comm/web]$ cd ../landing/
ashoat@ashoatmbp2021 [~/src/comm/landing]$ git grep "'click'"
ashoat@ashoatmbp2021 [~/src/comm/landing]$

Looks like we're good!

This revision was landed with ongoing or failed builds.Dec 23 2022, 10:18 AM

Closed by commit rCOMM1140d1ef8fcf: [web] Prevent web Menu from dismissing itself on open (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1140d1ef8fcf: [web] Prevent web Menu from dismissing itself on open.

Harbormaster completed remote builds in B14720: Diff 20073.Dec 23 2022, 10:22 AM