Page MenuHomePhabricator
Differential D6018

[landing] Fix SIWE behavior when no wallet installed on Android
ClosedPublic
Actions

Authored by ashoat on Dec 23 2022, 3:02 PM.
Tags
None
Referenced Files
F2905224: D6018.diff
Sun, Oct 6, 4:01 AM
Unknown Object (File)
Wed, Sep 11, 12:58 AM
Unknown Object (File)
Sat, Sep 7, 11:46 PM
Unknown Object (File)
Sep 5 2024, 6:06 AM
Unknown Object (File)
Sep 5 2024, 6:06 AM
Unknown Object (File)
Sep 5 2024, 5:47 AM
Unknown Object (File)
Sep 5 2024, 5:07 AM
Unknown Object (File)
Sep 5 2024, 3:40 AM
View All 92 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMfc8274f85981: [landing] Fix SIWE behavior when no wallet installed on Android
Summary

Pulled this from here. Our patch is a little different because we're using an old version of Rainbowkit.

Test Plan

Confirm links work when no wallet installed on Android emulator

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/siwe
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 23 2022, 3:02 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 23 2022, 3:02 PM
Harbormaster completed remote builds in B14726: Diff 20083.Dec 23 2022, 3:15 PM
ashoat requested review of this revision.Dec 23 2022, 3:15 PM
ashoat added a child revision: D6017: [native][landing] Resize BottomSheet when WalletConnect opened.Dec 23 2022, 3:23 PM
ashoat removed a child revision: D6017: [native][landing] Resize BottomSheet when WalletConnect opened.
ashoat added a parent revision: D6017: [native][landing] Resize BottomSheet when WalletConnect opened.
ashoat added a child revision: D6019: [native] Animate BottomSheet closed on goBackToPrompt.
atul accepted this revision.Dec 23 2022, 4:05 PM
This revision is now accepted and ready to land.Dec 23 2022, 4:05 PM
Closed by commit rCOMMfc8274f85981: [landing] Fix SIWE behavior when no wallet installed on Android (authored by ashoat). · Explain WhyDec 23 2022, 8:27 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfc8274f85981: [landing] Fix SIWE behavior when no wallet installed on Android.
ashoat mentioned this in rCOMM8c016d1beb79: [landing] Revert RainbowKit patch in D6018.Dec 30 2022, 5:19 PM

Revision Contents
Changeset List

PathSize
patches/
29 lines

Diff 20083

View Options

patches/@rainbow-me+rainbowkit+0.5.3.patch

Loading...