Page MenuHomePhabricator

UI changes on native to allow account deletion for SIWE accounts
ClosedPublic

Authored by marcin on Dec 29 2022, 4:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:51 AM
Unknown Object (File)
Fri, Nov 8, 9:51 AM
Unknown Object (File)
Tue, Nov 5, 1:40 AM
Unknown Object (File)
Tue, Nov 5, 1:39 AM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Subscribers

Details

Summary

This differential adjusts account deletion panel on native to allow account deletion for SIWE accounts and still require non-empty password to delete conventional account.

Test Plan

For conventional account - ensure deletion process is not altered. For SIWE accounts - go to account deleter panel and ensure there is no password input prompt and just clicking on DELETE button succesfully deletes account.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:53 AM
Harbormaster failed remote builds in B14917: Diff 20334!
This revision is now accepted and ready to land.Dec 29 2022, 6:41 AM
native/profile/delete-account.react.js
257 ↗(On Diff #20334)

We can consider checking if account has password here

Could you share a screenshot of the component without the password prompt?

In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

IMG_0002.PNG (2×1 px, 218 KB)

For conventional account
Zrzut ekranu 2022-12-29 o 16.05.29.png (2×1 px, 140 KB)

native/profile/delete-account.react.js
257 ↗(On Diff #20334)

You are right - it should simplify the code.

In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

IMG_0002.PNG (2×1 px, 218 KB)

For conventional account
Zrzut ekranu 2022-12-29 o 16.05.29.png (2×1 px, 140 KB)

The images don't show for me. https://www.notion.so/commapp/Attaching-files-and-images-on-Phabricator-af8e2195fc91462689cc8de5c96a6759

Use direct selector with accountHasPassword