Differential D6105

Do not prompt for password when deleting thread on web
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 24, 11:55 AM

	Unknown Object (File)
	Thu, Feb 20, 8:24 PM

	Unknown Object (File)
	Mon, Feb 17, 9:04 PM

	Unknown Object (File)
	Sat, Feb 15, 11:29 PM

	Unknown Object (File)
	Sat, Feb 15, 11:29 PM

	Unknown Object (File)
	Sat, Feb 15, 11:29 PM

	Unknown Object (File)
	Fri, Feb 14, 7:24 AM

	Unknown Object (File)
	Fri, Feb 14, 7:23 AM

Subscribers

None

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM4d11be699d0f: Do not prompt for password when deleting thread on web

Summary

This differential removes requirement to provide password when deleting thread on web.

Test Plan

Make hardcoded changes in thread-settings-modal in web so that user can see UI to delete thread. Try deleting thread. "Permission not granted" alert should pop. Now change the code on the keyserver side in thread-deleters not to look at permissions in MySQL. Try deleting again. It should
work.

Diff Detail

Repository

Branch

marcin/eng-2541

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 8:42 AM

marcin published this revision for review.Dec 29 2022, 8:42 AM

marcin added a parent revision: D6104: Conditionally hide possibility to change password for SIWE accounts.

Harbormaster failed remote builds in B14930: Diff 20348!Dec 29 2022, 8:46 AM

Rebase master

Harbormaster completed remote builds in B14940: Diff 20358.Dec 29 2022, 9:03 AM

ashoat accepted this revision.Dec 29 2022, 9:57 AM

This revision is now accepted and ready to land.Dec 29 2022, 9:57 AM

Rebase before landing

marcin mentioned this in D6102: Ignore password when deleting thread on the server side.Dec 30 2022, 3:41 AM

Harbormaster completed remote builds in B14972: Diff 20423.Dec 30 2022, 3:52 AM

Closed by commit rCOMM4d11be699d0f: Do not prompt for password when deleting thread on web (authored by marcin). · Explain WhyDec 30 2022, 4:13 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM4d11be699d0f: Do not prompt for password when deleting thread on web.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

settings/

thread-settings-delete-tab.react.js

47 lines

Diff 20348

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...