Github CI doesn't like "make install" so the protobuf install script
was always failing to place the artifacts. Instead, use another step to install
protobuf instead.
Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
What are the pros/cons of using our existing install_protobuf.sh script vs. arduino/setup-protoc@v1? Kind of weird to use an Arduino-specific GH Action, but I presume install_protobuf.sh isn't working here because of the make install?
Ultimately defer to you and @atul, who have spent the most time thinking about this.
What are the pros/cons of using our existing install_protobuf.sh script vs. arduino/setup-protoc@v1? Kind of weird to use an Arduino-specific GH Action, but I presume install_protobuf.sh isn't working here because of the make install?
Ultimately defer to you and @atul, who have spent the most time thinking about this.
This is how I approached the problem at first, the problem is that github containers dont seem to like to have things installed on them:
Install the project... -- Install configuration: "" -- Installing: /usr/local/lib/libprotobuf-lite.so.3.15.8.0 CMake Error at cmake_install.cmake:52 (file): file INSTALL cannot copy file "/home/runner/work/comm/comm/native/android/scripts/protobuf/build/libprotobuf-lite.so.3.15.8.0" to "/usr/local/lib/libprotobuf-lite.so.3.15.8.0": Success. make: *** [Makefile:100: install] Error 1 ~/work/comm/comm/native/android/scripts/protobuf ~/work/comm/comm/native/android/scripts ~/work/comm/comm/native/android/scripts
from the "Install Protobuf" step in: https://github.com/CommE2E/comm/actions/runs/3798672610/jobs/6460542589. I had sudo make install added to the script.
I think this was resolved with https://github.com/CommE2E/comm/commit/e0cc8c5343edbcf933e5dcb0e96c4dadaa338d04? (kept landing and reverting that commit last night until it worked... the first attempts didn't)
This seemed to have worked the first time without issue. I would to avoid the order of install targets determining whether a pipeline is green.