Page MenuHomePhabricator

Remove react-native-notifications dependency from project
ClosedPublic

Authored by marcin on Jan 2 2023, 7:32 AM.
Tags
None
Referenced Files
F2137413: D6141.diff
Fri, Jun 28, 6:01 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 4:57 PM
Unknown Object (File)
Thu, Jun 27, 12:36 PM
Subscribers

Details

Summary

This differential removes react-native-notifications dependency from repo. changes in files were not created manually but by running: "yarn remove react-native-notifications" (in native directory) and then yarn cleaninstall (in project root).

Test Plan

Since all react-native-notifications are already removed and replaced, the only test plan we need is to successfully build the app

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2334
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin requested review of this revision.Jan 2 2023, 7:47 AM

Exciting!!

native/react-native.config.js
6

Good work catching this

This revision is now accepted and ready to land.Jan 3 2023, 10:34 AM