Avoid situtations where Apple updates "delete" nix from
PATH by adding nix to the PATH of user zsh and bash shells.
~/.zshenv, ~/.profile, ~/.bashrc, and ~/.bash_profile were chosen
to reflect the files that rustup also writes to.
Details
Details
./scripts/install_nix.sh # Should see it emit that it writes to ~/.zshenv # and potentionally others # Assert that it was written cat ~/.zshenv # Open new shell echo $PATH # Nix should have multiple paths if /etc/zshrc still sources Nix logic
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| scripts/install_nix.sh | ||
|---|---|---|
| 30–35 ↗ | (On Diff #20525) | Should we include ~/.zshrc? |
| scripts/install_nix.sh | ||
|---|---|---|
| 32–33 ↗ | (On Diff #20525) | Do we really need both of these? |
| scripts/install_nix.sh | ||
|---|---|---|
| 30–35 ↗ | (On Diff #20525) | ~/.zshenv always gets sourced, and I can avoid having to write to both ~/.zprofile (login shells) and ~/.zshrc (interactive shells). |
| 32–33 ↗ | (On Diff #20525) | potentially yes. ~/.bash_profile is for a login shell, and ~/.bashrc is for an interactive shells. Terminal on OS X will by default use a login shell for each new session, so if a user configures bash to be their default interpreter it will only source ~/.bash_profile. If they launch bash from zsh, then it will source ~/.bashrc. Having the line potentially execute multiple times shouldn't mess with any logic. |
| scripts/install_nix.sh | ||
|---|---|---|
| 32–33 ↗ | (On Diff #20525) | Should also mention that users can also configure iterm and Terminal to launch as interactive shell. So you can't really make assumptions. |
| scripts/install_nix.sh | ||
|---|---|---|
| 32–33 ↗ | (On Diff #20525) | Doesn't the default version of .bash_profile on macOS source .bashrc at the start? |
| scripts/install_nix.sh | ||
|---|---|---|
| 32–33 ↗ | (On Diff #20525) | We would need ~/.bashrc to source ~/.bash_profile for it work in every case. Once I get home again, I can check the reset m1 what the defaults are (forgot to enable ssh access after resetting last week) |
Comment Actions
I was just following what rustup does, as I assume they have had many years of refining what files need to be written to.
Comment Actions
This is really helpful context, would've been great to mention this at the start. Can you link to what you used as inspiration?
Comment Actions
During install:
$ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh ... This path will then be added to your PATH environment variable by modifying the profile files located at: /Users/jon/.profile /Users/jon/.bash_profile /Users/jon/.bashrc /Users/jon/.zshenv
Used the reset m1 to inspect what was written.
Comment Actions
This is really helpful context, would've been great to mention this at the start.
It was in the secondary paragraph of the summary.
~/.zshenv, ~/.profile, ~/.bashrc, and ~/.bash_profile were chosen to reflect the files that rustup also writes to.