[native] introduce C++ message spec for reactions
ClosedPublic
Actions

Authored by ginsu on Jan 5 2023, 10:30 AM.

Details

Reviewers

atul
tomek
marcin

Commits

rCOMM98c488716453: [native] introduce C++ message spec for reactions

Summary

introduce C++ message spec for reactions. This missing C++ message spec was triggering an error pop up telling the user that there was an "Error setting threadStore or messageStore"

Linear Task: ENG-2645

Test Plan

Reproducing the original error is a bit hit or miss for me, but after these changes I haven't seen the error pop up since

Diff Detail

Repository

rCOMM Comm

Branch

eng-2467

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 5 2023, 10:30 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 5 2023, 10:30 AM

Harbormaster completed remote builds in B15128: Diff 20628.Jan 5 2023, 10:44 AM

ginsu requested review of this revision.Jan 5 2023, 10:44 AM

ginsu added reviewers: atul, tomek.Jan 5 2023, 11:04 AM

ginsu edited the summary of this revision. (Show Details)Jan 5 2023, 2:02 PM

ashoat added a reviewer: marcin.Jan 5 2023, 4:24 PM

tomek accepted this revision.Jan 9 2023, 2:58 AM

This revision is now accepted and ready to land.Jan 9 2023, 2:58 AM

Closed by commit rCOMM98c488716453: [native] introduce C++ message spec for reactions (authored by ginsu). · Explain WhyJan 9 2023, 9:02 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM98c488716453: [native] introduce C++ message spec for reactions.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

PersistentStorageUtilities/

MessageOperationsUtilities/

MessageSpecs.h

4 lines

MessageSpecs/

ReactionMessageSpec.h

16 lines

Diff 20628

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h