Page MenuHomePhabricator
Differential D6248

[docs] Bring back to nix docs "Building and deploying the app" section
ClosedPublic
Actions

Authored by inka on Jan 12 2023, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 10:01 AM
Unknown Object (File)
Fri, Apr 5, 10:01 AM
Unknown Object (File)
Fri, Apr 5, 10:01 AM
Unknown Object (File)
Fri, Apr 5, 10:01 AM
Unknown Object (File)
Fri, Apr 5, 9:55 AM
Unknown Object (File)
Mon, Apr 1, 11:33 PM
Unknown Object (File)
Mon, Apr 1, 11:33 PM
Unknown Object (File)
Mon, Apr 1, 11:33 PM
View All 83 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMc10ae3b3495d: [docs] Bring back to nix docs "Building and deploying the app" section
Summary

As discussed in https://linear.app/comm/issue/ENG-2602/ip-port-in-dev-environmentmd the "Building and deploying the app" section is useful, so I'm bringing it back to the nix docs from which it was cut while moving the text from dev_environment.md
Here is this section in dev_environment.md : link

Test Plan

Viewed rendered markdown of nix_mobile_workflows.md

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 12 2023, 1:21 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 12 2023, 1:21 AM
inka added a reviewer: Restricted Owners Package.Jan 12 2023, 1:21 AM
Harbormaster completed remote builds in B15287: Diff 20846.Jan 12 2023, 1:35 AM
inka requested review of this revision.Jan 12 2023, 1:35 AM
inka retitled this revision from Bring back to nix docs >Building and deploying the app< section to [docs] Bring back to nix docs >Building and deploying the app< section.Jan 12 2023, 1:40 AM
inka retitled this revision from [docs] Bring back to nix docs >Building and deploying the app< section to [docs] Bring back to nix docs "Building and deploying the app" section.
inka edited the summary of this revision. (Show Details)Jan 12 2023, 2:17 AM
ashoat accepted this revision.Jan 12 2023, 7:42 AM

Please address comment before landing, here and in docs/dev_environment.md

docs/nix_mobile_workflows.md
93 ↗(On Diff #20846)

This actually isn't true anymore... we should remove this line, in the old docs and the new

This revision is now accepted and ready to land.Jan 12 2023, 7:42 AM
inka added inline comments.Jan 17 2023, 6:24 AM
docs/nix_mobile_workflows.md
93 ↗(On Diff #20846)

Te same information is under Running mobile app on iOS Simulator, so I'll do that as a separate diff, and rebase this one on it, if that's ok.
So then this diff will be copying the updated, correct text.

inka added inline comments.Jan 17 2023, 6:30 AM
docs/nix_mobile_workflows.md
93 ↗(On Diff #20846)

D6280

inka updated this revision to Diff 20998.Jan 17 2023, 6:34 AM

Remove untrue sentence

Harbormaster completed remote builds in B15398: Diff 20998.Jan 17 2023, 6:48 AM
ashoat accepted this revision.Jan 17 2023, 7:09 AM
inka added a parent revision: D6280: [docs] Remove sentences stating that yarn dev in native runs redux.Jan 17 2023, 7:48 AM
inka added a child revision: D6249: [docs] Fix keyserver port numer, add instructions for connecting from physical device.Jan 17 2023, 8:00 AM
Closed by commit rCOMMc10ae3b3495d: [docs] Bring back to nix docs "Building and deploying the app" section (authored by • InkaSokolowska). · Explain WhyJan 17 2023, 8:07 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMc10ae3b3495d: [docs] Bring back to nix docs "Building and deploying the app" section.

Revision Contents
Changeset List

PathSize
docs/
17 lines

Diff 21022

View Options

docs/nix_mobile_workflows.md

Loading...