[Old blob] Fix build
AbandonedPublicDraft
Actions

Authored by • jon on Jan 17 2023, 1:08 PM.

Details

Reviewers

bartek
varun
atul
• max

Summary

After it was put in the "old" directory, the relative path was invalidated

Noticed when reviewing https://phab.comm.dev/D6290

Test Plan

cd services/backup/old/blob_client/
cargo build

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/fix-old-blob-client

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jan 17 2023, 1:08 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 17 2023, 1:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 17 2023, 1:11 PM

Harbormaster failed remote builds in B15421: Diff 21029!

Wow, I was sure I committed this change, my bad. Thanks for fixing this!

Edit: Ah, ok - this was meant to be run in docker container of which file structure doesn't have that one extra nested dir.

I don't think it's worth bothering, I'm gonna delete the entire old dir this/next week anyway: https://linear.app/comm/issue/ENG-2403/backup-service-remove-old-c-code

I don't think it's worth bothering, I'm gonna delete the entire old dir this/next week anyway: https://linear.app/comm/issue/ENG-2403/backup-service-remove-old-c-code

I'll abandon then. Sounds good

bartek mentioned this in D6312: [services][backup] Remove old C++ implementation.Jan 19 2023, 11:46 AM

bartek mentioned this in rCOMMaf2470e1e909: [services][backup] Remove old C++ implementation.Jan 23 2023, 6:01 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

old/

blob_client/

build.rs

2 lines

Diff 21029

View Options

services/backup/old/blob_client/build.rs

[Old blob] Fix buildAbandonedPublicDraftActions