Page MenuHomePhabricator
Differential D6295

Modify notification displayed from Java so that it opens the app when clicked
ClosedPublic
Actions

Authored by marcin on Jan 18 2023, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:40 AM
Unknown Object (File)
Mon, Dec 2, 2:38 AM
Unknown Object (File)
Thu, Nov 21, 8:31 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMc631afca39c5: Modify notification displayed from Java so that it opens the app when clicked
Summary

Previous differential in this stack disable the functionality that we open the app and navigate to relevant thread when notification is tapped. This differential brings back the first half of this functionality - tapping notification opens the app.

Test Plan

Build the app. Kill it. Send notification. Tap it. Ensure app opens (but not to the thread yet).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jan 18 2023, 6:49 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 18 2023, 6:49 AM
marcin added a parent revision: D6275: Stop subclassing RNFirebaseMessagingService as its functionality is not used anymore.Jan 18 2023, 6:50 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2023, 6:53 AM
Harbormaster failed remote builds in B15428: Diff 21037!
marcin added a child revision: D6296: Send event to JavaScript when notification is tapped so that we navigate to the thread.Jan 18 2023, 6:55 AM
marcin requested review of this revision.Jan 18 2023, 8:07 AM
tomek accepted this revision.Jan 18 2023, 10:03 AM
tomek added 1 blocking reviewer(s): bartek.

Looks ok but it is a good idea for @bartek to also take a look.

As a side note, it would be better to not introduce intermediate breaking changes. So this diff should be put before the diff that broke this functionality.

bartek accepted this revision.Jan 19 2023, 10:21 AM

Looks good to me

This revision is now accepted and ready to land.Jan 19 2023, 10:21 AM
marcin updated this revision to Diff 21453.Jan 27 2023, 6:40 AM

Rebase before landing

Harbormaster completed remote builds in B15732: Diff 21453.Jan 27 2023, 6:53 AM
marcin updated this revision to Diff 21569.Jan 30 2023, 3:10 AM

Rebase before landing

Harbormaster completed remote builds in B15823: Diff 21569.Jan 30 2023, 3:24 AM
Closed by commit rCOMMc631afca39c5: Modify notification displayed from Java so that it opens the app when clicked (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMc631afca39c5: Modify notification displayed from Java so that it opens the app when clicked.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
notifications/
22 lines

Diff 21596

View Options

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java

Loading...