Page MenuHomePhabricator
Differential D6304

[web] Add SIWE copy to `siweLoginForm`
ClosedPublic
Actions

Authored by atul on Jan 18 2023, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:39 PM
Unknown Object (File)
Sat, Nov 9, 10:09 PM
Unknown Object (File)
Fri, Nov 1, 5:02 PM
Unknown Object (File)
Fri, Nov 1, 5:02 PM
Unknown Object (File)
Fri, Nov 1, 5:01 PM
Unknown Object (File)
Fri, Nov 1, 4:59 PM
Unknown Object (File)
Fri, Nov 1, 4:40 PM
Unknown Object (File)
Oct 27 2024, 9:20 AM
View All 61 Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMM586bc22f6431: [web] Add SIWE copy to `siweLoginForm`
Summary

Same copy we use on landing. Includes some styling tweaks to ensure that things look reasonable.

Test Plan

Here's what it looks like:

c4ddc0-1.png (1×1 px, 195 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 18 2023, 6:26 PM
atul published this revision for review.Jan 18 2023, 6:26 PM
atul edited the test plan for this revision. (Show Details)
atul mentioned this in D6303: [web] Rename `siweConnectButton` to `siweLoginForm`.Jan 18 2023, 6:31 PM
ashoat accepted this revision.Jan 18 2023, 6:36 PM
ashoat added inline comments.
web/account/siwe.react.js
110–111 ↗(On Diff #21057)

Can we avoid copy-paste? Maybe this could be in lib as an array with two strings. React should automatically convert the apostrophe character to ' I think

This revision is now accepted and ready to land.Jan 18 2023, 6:36 PM
Harbormaster completed remote builds in B15445: Diff 21057.Jan 18 2023, 6:41 PM
atul added inline comments.Jan 18 2023, 11:02 PM
web/account/siwe.react.js
110–111 ↗(On Diff #21057)

Sure, can move to lib... wanted to avoid indirection but isn't great that we're copy/pasting either

atul updated this revision to Diff 21067.Jan 19 2023, 12:03 AM

pull out siweMessageSigningExplanationStatements

Harbormaster completed remote builds in B15449: Diff 21067.Jan 19 2023, 12:17 AM
ashoat added inline comments.Jan 19 2023, 8:53 AM
lib/utils/siwe-utils.js
76

Can you use an apostrophe instead of a single quote?

Closed by commit rCOMM586bc22f6431: [web] Add SIWE copy to `siweLoginForm` (authored by atul). · Explain WhyJan 19 2023, 5:10 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM586bc22f6431: [web] Add SIWE copy to `siweLoginForm`.
ashoat added inline comments.Jan 19 2023, 6:03 PM
lib/utils/siwe-utils.js
76

Ah I think you missed this comment

atul added inline comments.Jan 20 2023, 11:39 AM
lib/utils/siwe-utils.js
76

Ah crap, I'll update in a followup diff.

atul mentioned this in D6325: [lib] Replace single quote with apostrophe in `siweMessageSigningExplanationStatements`.Jan 20 2023, 11:41 AM
atul mentioned this in rCOMM27d01f3d5322: [lib] Replace single quote with apostrophe in….Jan 21 2023, 1:57 PM

Revision Contents
Changeset List

PathSize
landing/
2 lines
11 lines
lib/
utils/
10 lines
web/
account/
8 lines
9 lines
splash/
3 lines

Diff 21067

View Options

landing/siwe.css

Loading...
View Options

landing/siwe.react.js

Loading...
View Options

lib/utils/siwe-utils.js

Loading...
View Options

web/account/siwe.css

Loading...
View Options

web/account/siwe.react.js

Loading...
View Options

web/splash/splash.css

Loading...