[Nix Docs] Ensure Xcode install comes before yarn cleaninstall
ClosedPublic
Actions

Authored by • jon on Jan 19 2023, 3:29 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM6e7cd78375b5: [Nix Docs] Ensure Xcode install comes before yarn cleaninstall

Summary

The postinstall hook needs the iOS SDK to be available. Ensure that
it is installed before running 'yarn cleaninstall'

https://linear.app/comm/issue/ENG-2773

Test Plan

From a new system, follow the instructions to install the xcode commandline tools,
Xcode, and nix. The run:

yarn cleaninstall

# ensure that the postinstall hook is working
cd native/
yarn postinstall

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 19 2023, 3:29 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptJan 19 2023, 3:29 PM

Harbormaster completed remote builds in B15486: Diff 21125.Jan 19 2023, 3:44 PM

• jon requested review of this revision.Jan 19 2023, 3:44 PM

ashoat requested changes to this revision.Jan 19 2023, 3:51 PM

ashoat added inline comments.

docs/nix_dev_env.md
82 ↗	(On Diff #21125)	This is now a broken link

This revision now requires changes to proceed.Jan 19 2023, 3:51 PM

Remove link to removed section

Harbormaster completed remote builds in B15510: Diff 21157.Jan 20 2023, 1:07 PM

• jon added inline comments.Jan 20 2023, 1:30 PM

docs/nix_dev_env.md
82 ↗	(On Diff #21125)	Yep my bad. But we should implement a broken link linter for doc PRs. Created https://linear.app/comm/issue/ENG-2774/implement-broken-link-linter-for-documentation

ashoat accepted this revision.Jan 20 2023, 5:31 PM

This revision is now accepted and ready to land.Jan 20 2023, 5:31 PM

Closed by commit rCOMM6e7cd78375b5: [Nix Docs] Ensure Xcode install comes before yarn cleaninstall (authored by • jon). · Explain WhyJan 23 2023, 7:12 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM6e7cd78375b5: [Nix Docs] Ensure Xcode install comes before yarn cleaninstall.

Revision Contents
Changeset List

Path

Size

docs/

nix_dev_env.md

7 lines

nix_mobile_setup.md

6 lines

Diff 21185

View Options

docs/nix_dev_env.md