[Android] Glob over individual commoncpp directories
ClosedPublic
Actions

Authored by • jon on Jan 20 2023, 1:25 PM.

Tags

None

Referenced Files

	F2829542: D6327.diff
	Fri, Sep 27, 4:43 PM

	Unknown Object (File)
	Mon, Sep 16, 3:36 AM

	Unknown Object (File)
	Thu, Sep 12, 4:21 AM

	Unknown Object (File)
	Thu, Sep 12, 4:21 AM

	Unknown Object (File)
	Thu, Sep 12, 4:21 AM

	Unknown Object (File)
	Thu, Sep 12, 4:16 AM

	Unknown Object (File)
	Sun, Sep 1, 5:25 PM

	Unknown Object (File)
	Thu, Aug 29, 5:06 PM

View All 71 Files

Subscribers

ashoat

Details

Reviewers

• max
tomek
atul
varun
ashoat

Commits

rCOMM947857cfda6b: [Android] Glob over individual commoncpp directories

Summary

To iteratively chip away at the GLOB_RECURSIVE monolith, we divide
the the files being GLOB'd to the individual folders.

This change should be removed completely once we fully reference the CMake logic
in native/cpp/CommonCpp

https://linear.app/comm/issue/ENG-2757

Test Plan

Android CI build passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 20 2023, 1:25 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2023, 1:25 PM

Harbormaster completed remote builds in B15511: Diff 21158.Jan 20 2023, 1:40 PM

• jon requested review of this revision.Jan 20 2023, 1:40 PM

Nice!!

This revision is now accepted and ready to land.Jan 20 2023, 5:32 PM

Closed by commit rCOMM947857cfda6b: [Android] Glob over individual commoncpp directories (authored by • jon). · Explain WhyJan 23 2023, 7:21 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM947857cfda6b: [Android] Glob over individual commoncpp directories.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

18 lines

Diff 21195

View Options

native/android/app/CMakeLists.txt

[Android] Glob over individual commoncpp directoriesClosedPublicActions