[native] Add presentation: 'transparentModal' to termsAndPrivacyModalScreenOptions
ClosedPublic
Actions

Authored by ashoat on Jan 21 2023, 1:00 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMMeed677f06727: [native] Add presentation: 'transparentModal' to…

Summary

I should've covered this in D5891. Without this, I think the screen behind the modal won't appear on Android.

Test Plan

I haven't had a chance to test this, but my theory is that without this, the Terms & Privacy modal appears on Android with the background completely black. @kamil, have you seen this on Android?

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 21 2023, 1:00 PM

Herald added a subscriber: atul. · View Herald TranscriptJan 21 2023, 1:00 PM

ashoat edited the test plan for this revision. (Show Details)Jan 21 2023, 1:00 PM

Harbormaster completed remote builds in B15514: Diff 21161.Jan 21 2023, 1:15 PM

ashoat requested review of this revision.Jan 21 2023, 1:15 PM

kamil accepted this revision.Jan 23 2023, 7:03 AM

kamil added inline comments.

native/navigation/root-navigator.react.js
162	I haven't had a chance to test this, but my theory is that without this, the Terms & Privacy modal appears on Android with the background completely black. @kamil, have you seen this on Android? I've seen it, but I thought it was supposed to look like this because I compared it to other app modals I tested this for you Before: After:

This revision is now accepted and ready to land.Jan 23 2023, 7:03 AM

FYI I can't see those screenshots because of this issue, but I assume you're showing that the change was positive since you accepted the diff, so I'll go ahead and land

kamil attached a referenced file: F339593: image.png. (Show Details)Jan 23 2023, 8:55 AM

Closed by commit rCOMMeed677f06727: [native] Add presentation: 'transparentModal' to… (authored by ashoat). · Explain WhyJan 23 2023, 8:55 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMeed677f06727: [native] Add presentation: 'transparentModal' to….

kamil attached a referenced file: F339592: image.png. (Show Details)Jan 23 2023, 8:55 AM