[Nix] Fix undeclared failure
ClosedPublic
Actions

Authored by • jon on Jan 26 2023, 1:09 PM.

Tags

None

Referenced Files

	F3491928: D6404.id21467.diff
	Wed, Dec 18, 9:20 PM

	F3490061: D6404.diff
	Wed, Dec 18, 2:43 PM

	Unknown Object (File)
	Nov 11 2024, 4:46 AM

	Unknown Object (File)
	Nov 10 2024, 5:18 AM

	Unknown Object (File)
	Oct 29 2024, 5:21 PM

	Unknown Object (File)
	Oct 22 2024, 7:32 AM

	Unknown Object (File)
	Sep 30 2024, 4:51 AM

	Unknown Object (File)
	Sep 30 2024, 4:51 AM

View All 48 Files

Subscribers

ashoat

tomek

Details

Reviewers

varun
atul

Commits

rCOMM13422ce6745b: [Nix] Fix undeclared failure

Summary

'set -u' will error if a variable is unset. Add bash
substitution to prevent the undefined variable causing an error.

https://linear.app/comm/issue/ENG-2838

Test Plan

PS1= ./scripts/prompt_macos_direnv.sh

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/test-ps1

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jan 26 2023, 1:09 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 26 2023, 1:09 PM

Harbormaster completed remote builds in B15690: Diff 21395.Jan 26 2023, 1:24 PM

• jon requested review of this revision.Jan 26 2023, 1:24 PM

atul accepted this revision.Jan 26 2023, 2:42 PM

This revision is now accepted and ready to land.Jan 26 2023, 2:42 PM

varun accepted this revision.Jan 26 2023, 9:04 PM

Closed by commit rCOMM13422ce6745b: [Nix] Fix undeclared failure (authored by • jon). · Explain WhyJan 27 2023, 9:42 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM13422ce6745b: [Nix] Fix undeclared failure.

Revision Contents
Changeset List

Path

Size

scripts/

prompt_direnv_macos.sh

2 lines

Diff 21395

View Options

scripts/prompt_direnv_macos.sh

[Nix] Fix undeclared failureClosedPublicActions