Page MenuHomePhabricator

[Nix] Fail immediately when upstream nix install fails
ClosedPublic

Authored by jon on Jan 30 2023, 3:18 PM.
Tags
None
Referenced Files
F1830652: D6475.id22130.diff
Thu, May 23, 9:43 AM
Unknown Object (File)
Mon, May 13, 8:12 PM
Unknown Object (File)
Apr 22 2024, 12:21 AM
Unknown Object (File)
Apr 22 2024, 12:21 AM
Unknown Object (File)
Apr 22 2024, 12:21 AM
Unknown Object (File)
Apr 22 2024, 12:13 AM
Unknown Object (File)
Feb 27 2024, 9:19 PM
Unknown Object (File)
Feb 27 2024, 9:19 PM
Subscribers

Details

Summary

Propagate failures when running the upstream nix install script.
This is to avoid the case where the failure gets buried by the output
of the rest of the command.

Part of https://linear.app/comm/issue/ENG-2877

Test Plan
# If nix is not already installed, install it
./scripts/install_nix.sh

# Unset nix from PATH, then re-run script
PATH=/usr/bin:/bin ./scripts/install_nix.sh
# Anwser yes to the prompts, then assert that it fails without
# trying to continue with the script (e.g. nix.conf changes)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable