Page MenuHomePhabricator
Differential D6478

[lib] Replace threadSearchIndex selector with useGlobalThreadSearchIndex hook
ClosedPublic
Actions

Authored by ashoat on Jan 31 2023, 5:04 AM.
Tags
None
Referenced Files
F3509149: D6478.diff
Sat, Dec 21, 1:40 AM
Unknown Object (File)
Nov 8 2024, 3:12 AM
Unknown Object (File)
Oct 29 2024, 3:20 PM
Unknown Object (File)
Sep 30 2024, 4:25 PM
Unknown Object (File)
Sep 30 2024, 4:25 PM
Unknown Object (File)
Sep 30 2024, 4:25 PM
Unknown Object (File)
Sep 30 2024, 4:23 PM
Unknown Object (File)
Sep 20 2024, 6:41 PM
View All 71 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMf882deb936df: [lib] Replace threadSearchIndex selector with useGlobalThreadSearchIndex hook
Summary

Depends on D6477

Test Plan

There were six surfaces affected by this change:

  1. ThreadPickerModal on native
  2. ThreadPickerModal on web
  3. ChatThreadList on native
  4. ThreadListProvider on web (surfaced through ChatThreadList)
  5. SidebarsModal on web
  6. SubchannelsModal on web

I tested all of them:

Screenshot 2023-01-31 at 8.01.37 AM.png (2×1 px, 832 KB)
Screenshot 2023-01-31 at 8.01.46 AM.png (1×1 px, 93 KB)
Screenshot 2023-01-31 at 8.01.55 AM.png (2×1 px, 866 KB)
Screenshot 2023-01-31 at 8.02.01 AM.png (1×832 px, 187 KB)
Screenshot 2023-01-31 at 8.04.24 AM.png (1×838 px, 82 KB)
Screenshot 2023-01-31 at 8.04.12 AM.png (1×832 px, 57 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
hooks/
4 lines
selectors/
33 lines
shared/
5 lines
native/
calendar/
4 lines
chat/
4 lines
web/
modals/
threads/
4 lines

Diff 21674

View Options

lib/hooks/child-threads.js

Loading...
View Options

lib/selectors/nav-selectors.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/calendar/thread-picker-modal.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

web/modals/threads/thread-picker-modal.react.js

Loading...