Match SIWE web designs: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7646%3A134916&t=6T70eVfC0cqPSbXJ-1
Depends on D6481
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Are you sure we need to use those colors, versus using ones in the design system? Did you check with Dave? I would prefer to keep the design system colors unless the design team indicated otherwise
Comment Actions
Are you sure we need to use those colors, versus using ones in the design system? Did you check with Dave? I would prefer to keep the design system colors unless the design team indicated otherwise
We talked about updating the layout, colors, and navigation structure to match the SIWE web designs, so I assume changing these button colors was in scope and intentional. I can send him a message to double check and can revert if necessary.
(Personally think the LoginForm looks much better after the color changes.)
Comment Actions
I can send him a message to double check and can revert if necessary.
Would be great if you could do that
Comment Actions
The colors being used here are from the "new design system" that's being worked on as part of the "New UI Themes" task. Dave is open to sticking with the current design system for this SIWE web work instead of using the new colors.
Personally, I think this change is consistent with the way things are moving design-wise and would prefer to use these new colors rather than the old ones which look really bad.
I'll just abandon this diff and stick to layout/navigation changes.