Page MenuHomePhabricator

[keyserver] enable accepting policies feature
ClosedPublic

Authored by kamil on Feb 1 2023, 7:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 5:45 AM
Unknown Object (File)
Tue, Dec 17, 5:45 AM
Unknown Object (File)
Tue, Dec 17, 5:45 AM
Unknown Object (File)
Tue, Dec 17, 5:45 AM
Unknown Object (File)
Tue, Dec 17, 5:40 AM
Unknown Object (File)
Nov 18 2024, 7:25 PM
Unknown Object (File)
Nov 16 2024, 10:24 PM
Unknown Object (File)
Nov 16 2024, 9:34 PM
Subscribers

Details

Summary

Updating code version because feature is released. Setting date to run script properly.

Test Plan
  1. Test if yarn script dist/scripts/force-policy-acknowledgment.js works properly.
  2. Test if accepting policy works on native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil added inline comments.
keyserver/src/scripts/force-policy-acknowledgment.js
9 ↗(On Diff #21758)

As I said here it is possible to release this tomorrow: https://phab.comm.dev/D6394#inline-43367. Concrete time is not needed (shouldn't cause any harm) so just pushing the date to the next day

kamil published this revision for review.Feb 1 2023, 9:43 AM
atul requested changes to this revision.Feb 1 2023, 10:21 AM
atul added inline comments.
keyserver/src/utils/validation-utils.js
166 ↗(On Diff #21758)

We should make this 183 and it should be good to land

This revision now requires changes to proceed.Feb 1 2023, 10:21 AM
kamil requested review of this revision.Feb 1 2023, 10:34 AM

Requesting review to get the answer

keyserver/src/utils/validation-utils.js
166 ↗(On Diff #21758)

Sorry, but could you say why is that? All native changes are included in yesterday's release, represented by this commit. I am not sure why we need to bump the version higher

atul requested changes to this revision.Feb 1 2023, 10:37 AM
atul added inline comments.
keyserver/src/utils/validation-utils.js
166 ↗(On Diff #21758)

Ah okay then we should make it 181 which is the first in the "pair" (181 is the public release paired with 182 which is the staff release)

This revision now requires changes to proceed.Feb 1 2023, 10:37 AM

update version to 181

keyserver/src/utils/validation-utils.js
166 ↗(On Diff #21758)

that makes sense to me, thanks for catching it!

Looks good! Sorry for the churn

This revision is now accepted and ready to land.Feb 1 2023, 10:48 AM