reacted
ClosedPublic
Actions

Authored by ginsu on Feb 1 2023, 12:20 PM.

Details

Reviewers

atul
tomek
rohan
ashoat

Commits

rCOMM418a1d782e3d: [lib] change reaction message title/notif text from liked => reacted

Summary

change reaction message title/notif text from liked => reacted. This is the first step to improving the reaction message title/notif text

Test Plan

Please see the screenshots to see the changes I made

Before:

Screenshot 2023-02-01 at 3.13.26 PM.png (540×1 px, 121 KB)

Screenshot 2023-02-01 at 3.13.39 PM.png (312×968 px, 37 KB)

Screenshot 2023-02-01 at 3.23.21 PM.png (1×770 px, 1 MB)

Screenshot 2023-02-01 at 3.23.14 PM.png (1×798 px, 1 MB)

After:

Screenshot 2023-02-01 at 3.18.23 PM.png (1×858 px, 1 MB)

Screenshot 2023-02-01 at 3.18.11 PM.png (1×830 px, 1 MB)

Screenshot 2023-02-01 at 3.16.54 PM.png (356×1 px, 49 KB)

Screenshot 2023-02-01 at 3.17.05 PM.png (394×1 px, 79 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 1 2023, 12:20 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 1 2023, 12:20 PM

ginsu edited the test plan for this revision. (Show Details)Feb 1 2023, 12:23 PM

ginsu added reviewers: atul, tomek, rohan.

ginsu attached a referenced file: F356028: Screenshot 2023-02-01 at 3.17.05 PM.png. (Show Details)

ginsu attached a referenced file: F356029: Screenshot 2023-02-01 at 3.16.54 PM.png. (Show Details)

ginsu attached a referenced file: F356030: Screenshot 2023-02-01 at 3.18.11 PM.png. (Show Details)

ginsu attached a referenced file: F356031: Screenshot 2023-02-01 at 3.18.23 PM.png. (Show Details)

ginsu attached a referenced file: F356032: Screenshot 2023-02-01 at 3.23.14 PM.png. (Show Details)

ginsu attached a referenced file: F356033: Screenshot 2023-02-01 at 3.23.21 PM.png. (Show Details)

ginsu attached a referenced file: F356026: Screenshot 2023-02-01 at 3.13.39 PM.png. (Show Details)

ginsu attached a referenced file: F356027: Screenshot 2023-02-01 at 3.13.26 PM.png. (Show Details)

Harbormaster completed remote builds in B15949: Diff 21781.Feb 1 2023, 12:37 PM

ginsu requested review of this revision.Feb 1 2023, 12:37 PM

rohan accepted this revision.Feb 1 2023, 12:54 PM

This revision is now accepted and ready to land.Feb 1 2023, 12:54 PM

Adding @ashoat as blocking since these are copy changes

This revision now requires review to proceed.Feb 1 2023, 1:15 PM

ashoat accepted this revision.Feb 1 2023, 1:16 PM

This revision is now accepted and ready to land.Feb 1 2023, 1:16 PM

Closed by commit rCOMM418a1d782e3d: [lib] change reaction message title/notif text from liked => reacted (authored by ginsu). · Explain WhyFeb 1 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM418a1d782e3d: [lib] change reaction message title/notif text from liked => reacted.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

10 lines

Diff 21793

View Options

lib/shared/messages/reaction-message-spec.js

[lib] change reaction message title/notif text from liked => reactedClosedPublicActions