Page MenuHomePhabricator
Differential D6502

[web] Rename `SIWE` component to `SIWELoginForm`
ClosedPublic
Actions

Authored by atul on Feb 1 2023, 1:09 PM.
Tags
None
Referenced Files
F2158869: D6502.diff
Mon, Jul 1, 5:09 AM
Unknown Object (File)
Wed, Jun 26, 8:48 AM
Unknown Object (File)
Tue, Jun 25, 3:30 PM
Unknown Object (File)
Mon, Jun 24, 9:54 AM
Unknown Object (File)
Sat, Jun 22, 8:37 PM
Unknown Object (File)
Thu, Jun 6, 11:43 PM
Unknown Object (File)
May 25 2024, 12:46 AM
Unknown Object (File)
May 18 2024, 3:20 AM
View All 27 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
rohan
ginsu
Commits
rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm`
Summary

Clearer name and also parallel naming structure to TraditionalLoginForm and also distinguishes from SIWE component in landing.

Test Plan

NA, flow + things work as expected + searched codebase for usages of the web SIWE component and this was the only one.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 1 2023, 1:09 PM
atul published this revision for review.Feb 1 2023, 1:11 PM
ashoat accepted this revision.Feb 1 2023, 1:13 PM
This revision is now accepted and ready to land.Feb 1 2023, 1:13 PM
This revision was landed with ongoing or failed builds.Feb 1 2023, 1:20 PM
Closed by commit rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm`.
Harbormaster completed remote builds in B15954: Diff 21786.Feb 1 2023, 1:27 PM

Revision Contents
Changeset List

PathSize
web/
account/
4 lines
4 lines

Diff 21786

View Options

web/account/log-in-form.react.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...
View Options

web/account/siwe.react.js

Loading...