Paths

Table of Contentst

[scripts] change protobuf installation directory name
ClosedPublic
Actions

Authored by varun on Feb 1 2023, 10:18 PM.

Tags

None

Referenced Files

	F3397772: D6522.diff
	Sun, Dec 1, 7:27 PM

	Unknown Object (File)
	Thu, Nov 14, 8:20 PM

	Unknown Object (File)
	Thu, Nov 14, 8:20 PM

	Unknown Object (File)
	Thu, Nov 14, 8:20 PM

	Unknown Object (File)
	Nov 1 2024, 10:33 AM

	Unknown Object (File)
	Nov 1 2024, 10:32 AM

	Unknown Object (File)
	Nov 1 2024, 10:32 AM

	Unknown Object (File)
	Nov 1 2024, 10:13 AM

View All 91 Files

Subscribers

ashoat

Details

Reviewers

• jon
tomek
atul

Commits

rCOMMd0792ef21fff: [scripts] change protobuf installation directory name

Summary

The protobuf repo has a file named BUILD in it, so install_protobuf.sh fails with the error, mkdir: build: File exists. This appears to only be an issue on macOS, perhaps because Debian is case sensitive.

Test Plan

All the Buildkite CI workflows should pass

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Feb 1 2023, 10:18 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 1 2023, 10:18 PM

Harbormaster completed remote builds in B15987: Diff 21828.Feb 1 2023, 10:33 PM

varun requested review of this revision.Feb 1 2023, 10:33 PM

atul accepted this revision.Feb 2 2023, 5:46 AM

This revision is now accepted and ready to land.Feb 2 2023, 5:46 AM

Closed by commit rCOMMd0792ef21fff: [scripts] change protobuf installation directory name (authored by varun). · Explain WhyFeb 2 2023, 7:51 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMd0792ef21fff: [scripts] change protobuf installation directory name.

Revision Contents
Changeset List

Path

Size

scripts/

install_protobuf.sh

6 lines

Diff 21828

View Options

scripts/install_protobuf.sh

[scripts] change protobuf installation directory nameClosedPublicActions