[scripts] make install_protobuf script work on macos
ClosedPublic
Actions

Authored by varun on Feb 2 2023, 8:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 13, 3:37 PM

	Unknown Object (File)
	Sat, Apr 20, 6:18 AM

	Unknown Object (File)
	Apr 17 2024, 12:24 PM

	Unknown Object (File)
	Apr 17 2024, 12:24 PM

	Unknown Object (File)
	Apr 17 2024, 12:23 PM

	Unknown Object (File)
	Apr 17 2024, 12:18 PM

	Unknown Object (File)
	Mar 21 2024, 10:08 AM

	Unknown Object (File)
	Mar 21 2024, 10:08 AM

Subscribers

Details

Reviewers

• jon

Commits

rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos

Summary

nproc isn't a command on macos, so we need to use sysctl if it's not available

Test Plan

CI passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 2 2023, 8:33 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 2 2023, 8:33 AM

Harbormaster completed remote builds in B16011: Diff 21856.Feb 2 2023, 8:52 AM

varun requested review of this revision.Feb 2 2023, 8:52 AM

• jon accepted this revision.Feb 2 2023, 8:56 AM

This revision is now accepted and ready to land.Feb 2 2023, 8:56 AM

Closed by commit rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos (authored by varun). · Explain WhyFeb 2 2023, 9:06 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos.

Revision Contents
Changeset List

Path

Size

scripts/

install_protobuf.sh

2 lines

Diff 21865

View Options

scripts/install_protobuf.sh

[scripts] make install_protobuf script work on macosClosedPublicActions