Page MenuHomePhabricator

[native] add SafeAreaView to MessageReactionsModal
ClosedPublic

Authored by ginsu on Feb 2 2023, 12:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 10:21 AM
Unknown Object (File)
Thu, Jun 13, 10:59 PM
Unknown Object (File)
Thu, Jun 13, 10:59 PM
Unknown Object (File)
Thu, Jun 13, 7:27 PM
Unknown Object (File)
Tue, Jun 11, 8:29 AM
Unknown Object (File)
Sun, Jun 9, 6:46 AM
Unknown Object (File)
Fri, Jun 7, 9:11 PM
Unknown Object (File)
Fri, Jun 7, 9:10 PM
Subscribers

Details

Summary

add SafeAreaView to MessageReactionsModal. The SafeAreaView pushes the container of MessageReactionsModal up a bit to a place where things like the Android nav buttons won't overlap with the content of the modal


Linear Task: ENG-2846

Test Plan

Please review the screenshots below to see the changes I made

Before:

iOS:

Screenshot 2023-02-02 at 3.32.11 PM.png (1×1 px, 852 KB)

Android:

Screenshot 2023-02-02 at 1.17.10 PM.png (1×978 px, 415 KB)

After:

iOS:

Screenshot 2023-02-02 at 3.30.59 PM.png (1×1 px, 850 KB)

Android:

Screenshot 2023-02-02 at 3.29.27 PM.png (1×978 px, 422 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Feb 2 2023, 12:49 PM
This revision is now accepted and ready to land.Feb 2 2023, 3:46 PM
native/chat/message-reactions-modal.react.js
65

There's no reason to nest a SafeAreaView inside another SafeAreaView

native/chat/message-reactions-modal.react.js
65

Never mind, ignore this! I confused myself