Page MenuHomePhabricator

[CI] Automatic releases for desktop
ClosedPublic

Authored by michal on Feb 3 2023, 3:18 AM.
Tags
None
Referenced Files
F3490188: D6555.diff
Wed, Dec 18, 3:19 PM
Unknown Object (File)
Thu, Nov 21, 5:18 AM
Unknown Object (File)
Thu, Nov 21, 5:18 AM
Unknown Object (File)
Mon, Nov 18, 7:30 PM
Unknown Object (File)
Nov 15 2024, 11:38 PM
Unknown Object (File)
Nov 9 2024, 2:26 AM
Unknown Object (File)
Nov 9 2024, 2:25 AM
Unknown Object (File)
Nov 9 2024, 1:44 AM
Subscribers

Details

Summary

Part of ENG-2224. This new action uses artifacts from Windows/ macOS CI, to create a new release with the necessary files for a new desktop update. Release workflow is triggered on git tag push that starts with desktop-.

  • In the Windows/ macOS CI, new trigger is added - workflow_call so they can be called from other workflows. Additionaly they will save their artifacts so they can be transfered to the release workflow (they could be also useful for testing e.g. Windows changes).
  • Then a new release is created with the files. It's marked as prerelease so the update server ignores it and we can test it before marking it as a full release. The new release is linked in the workflow summary.

The official GitHub action for releases is unmaintained. The softprops action that I'm using is one of the mentioned alternatives and seems the most well-maintained. It needs permissions: content: write, which should be the default but I've figured I would state it explicitly.

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal requested review of this revision.Feb 3 2023, 3:32 AM
atul added inline comments.
.github/workflows/windows_ci.yml
4 ↗(On Diff #21937)

Can you explain why we're adding this?

This revision is now accepted and ready to land.Feb 4 2023, 12:05 PM
.github/workflows/windows_ci.yml
4 ↗(On Diff #21937)

@atul it's needed to call this workflow from another one. It's used by the desktop-release.yml in:

jobs:
  windows-build:
    uses: ./.github/workflows/windows_ci.yml