Details
Details
Please see the screenshots to see the changes I made
Before:
After:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/shared/messages/reaction-message-spec.js | ||
---|---|---|
171–175 ↗ | (On Diff #22126) | I wonder if we could reduce the copy-paste here, seems like this code is shared with messageTitle... you could introduce a new function in this file that handles lines 171-177 (which are shared with lines 55-60) |
lib/shared/messages/reaction-message-spec.js | ||
---|---|---|
171–175 ↗ | (On Diff #22126) | The notif text uses your message while the title text uses a message, but if we still want to make this update, I can update this diff later in the day |
lib/shared/messages/reaction-message-spec.js | ||
---|---|---|
171–175 ↗ | (On Diff #22126) | Ah nvm, good catch |