Differential D6644
[native] factor out emojiKeyboard shared value from tooltip component Authored by ginsu on Feb 6 2023, 11:03 PM. Tags None Referenced Files
Details factor out emojiKeyboard shared value from the tooltip component into tooltip-context.react. Also noticed that the emoji keyboard was not stopping the navigation from going back, so fixed that as well using the new refactored logic Linear Task: ENG-2937 Please see the demo video to see that everything still works as expected
Diff Detail
Event TimelineComment Actions This achieves nothing – the code is still in TooltipContext. It's important to understand the motivation here... I'm not asking you to remove this from Tooltip for arbitrary reasons, I'm asking you to make sure we're able to achieve separation of concerns, and to remove all application-specific code from the tooltip code. The tooltip code is meant to be general purpose. When you find yourself wanting to hack a general purpose component to achieve a goal, ask yourself "how could I extend the API of this general purpose component to be able to do what I need, without introducing application-specific code?" Comment Actions Please chat with me IRL before proceeding on this task – I want to make sure you don't waste any more cycles |