Page MenuHomePhabricator

[native] Introduce setRouteParams action on OverlayRouter
ClosedPublic

Authored by ashoat on Feb 7 2023, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Fri, Nov 15, 6:51 PM
Unknown Object (File)
Fri, Nov 15, 6:51 PM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
Unknown Object (File)
Sat, Nov 9, 12:42 AM
Subscribers
None

Details

Summary

setParams lets us set params for the current route, but we need to set params for another route.

navigate lets us set params for an existing route, but because it doesn't know if the route already exists or not, it needs the full list of params (instead of just a $Shape of them).

This new action will only work if the route exists already.

Test Plan
  1. Opened robotext and text tooltips
  2. Mocked an extra TooltipItem to show action sheet
  3. Made sure tooltip is hidden when action sheet is opened
  4. Selected an emoji from the popover. Confirmed everything dismisses at the same time
  5. Selected an emoji from the emoji picker. Confirmed everything dismisses at the same time
  6. Pressed the background and confirmed everything dismisses at the same time
  7. Pressed the copy button to make sure that everything dismisses at the same time

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable