Page MenuHomePhabricator

[native] Clean up Tooltip transition state
ClosedPublic

Authored by ashoat on Feb 7 2023, 2:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Fri, Nov 15, 6:51 PM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
Unknown Object (File)
Sat, Nov 9, 12:42 AM
Subscribers
None

Details

Summary

Currently we have three places state about Tooltip transition is stored:

  1. actionSheetShown
  2. showEmojiKeyboard
  3. hideTooltip

This diff moves hideTooltip to ReactNav params so it can be modified outside of the component. The showEmojiKeyboard stuff has been moved to the individual button components. And actionSheetShown is no longer necessary, and has been deduped with the others.

Depends on D6657

Test Plan
  1. Opened robotext and text tooltips
  2. Mocked an extra TooltipItem to show action sheet
  3. Made sure tooltip is hidden when action sheet is opened
  4. Selected an emoji from the popover. Confirmed everything dismisses at the same time
  5. Selected an emoji from the emoji picker. Confirmed everything dismisses at the same time
  6. Pressed the background and confirmed everything dismisses at the same time
  7. Pressed the copy button to make sure that everything dismisses at the same time

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable