Page MenuHomePhabricator

[keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`
AbandonedPublic

Authored by tomek on Feb 10 2023, 7:31 AM.
Tags
None
Referenced Files
F3488423: D6688.diff
Wed, Dec 18, 9:59 AM
Unknown Object (File)
Sat, Dec 14, 2:33 AM
Unknown Object (File)
Thu, Nov 28, 3:06 PM
Unknown Object (File)
Wed, Nov 20, 7:14 AM
Unknown Object (File)
Tue, Nov 19, 12:56 AM
Unknown Object (File)
Tue, Nov 19, 12:56 AM
Unknown Object (File)
Tue, Nov 19, 12:55 AM
Unknown Object (File)
Tue, Nov 19, 12:55 AM
Subscribers

Details

Reviewers
atul
max
Summary

This diff introduces changes to the Keyserver codebase to refactor the redisPublish function name to the messageBrokerPublish to reflect its abstraction type. According to our task, this function will publish not only to the Redis and to the Tunnelbroker.

Linear task: ENG-2613

Test Plan

Passing the CI is enough for these changes.

Diff Detail

Repository
rCOMM Comm
Branch
ks-refactor-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max retitled this revision from [keyserver] Refactor `redisPublish` function to `messageBrokerPublish` to [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.Feb 10 2023, 8:11 AM
max edited the test plan for this revision. (Show Details)
max added reviewers: atul, tomek.
max published this revision for review.Feb 13 2023, 5:57 AM

Seems like a straightforward rename, and looks like all usages were fixed:

7e0692.png (666×1 px, 115 KB)

keyserver/src/creators/update-creator.js
381

Should we rename this to promises.messageBroker?

This revision is now accepted and ready to land.Feb 13 2023, 9:20 AM
max edited the test plan for this revision. (Show Details)

Renaming promises.redis to promises.messageBroker.

max added inline comments.
keyserver/src/creators/update-creator.js
381

Should we rename this to promises.messageBroker?

Totally makes sense! I've renamed it. Thanks, @atul!

max marked an inline comment as done.

Fixing parent stack.

Rebasing on master and parent changes.

tomek abandoned this revision.
tomek edited reviewers, added: max; removed: tomek.

Not sure if we still need this - the Linear issue has been canceled for a long time.