Page MenuHomePhabricator
Differential D6707

[web] Update to copy-webpack-plugin@11.0.0
ClosedPublic
Actions

Authored by ashoat on Feb 12 2023, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:11 AM
Unknown Object (File)
Mon, Mar 24, 1:07 PM
Unknown Object (File)
Fri, Mar 21, 8:49 AM
Unknown Object (File)
Mon, Mar 17, 6:36 PM
Unknown Object (File)
Wed, Mar 12, 9:31 PM
Unknown Object (File)
Mar 2 2025, 8:01 PM
Unknown Object (File)
Mar 2 2025, 8:01 PM
Unknown Object (File)
Mar 2 2025, 8:00 PM
View All Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMMfbba6ba46e6f: [web] Update to copy-webpack-plugin@11.0.0
Summary

After updating to Webpack 5, I figured I'd update this related package as well.

Depends on D6706

Test Plan
  1. I tested dev build in web via yarn dev in web + keyserver and then tested the website
  2. I tested prod build by running yarn prod in web and then tested the website by running keyserver with yarn prod-build && yarn-prod
  3. I reviewed the releases on GitHub and though there were lots of breaking changes (mostly Node versions), found that none of them applied to us

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
2 lines
85 lines

Diff 22391

View Options

web/package.json

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

yarn.lock

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines