Reimplement generateRandomString using browser crypto module
ClosedPublic
Actions

Authored by ashoat on Feb 12 2023, 6:40 PM.

Details

Reviewers

inka
atul
tomek

Commits

rCOMMc2af4d6d0486: Reimplement generateRandomString using browser crypto module

Summary

generateRandomString is currently implemented using a polyfill of the Node.js crypto library, but Webpack 5 no longer includes this polyfill by default.

We could configure the polyfill manually, but instead I figured we could save some bundle size and just reimplement this using the browser-native crypto module, which has a getRandomValues function.

Test Plan

console.log'd the results of calling generateDeviceID in web

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 12 2023, 6:40 PM

ashoat added a child revision: D6698: [lib] Remove url-parse-lax from Webpack bundles.Feb 12 2023, 6:44 PM

Harbormaster completed remote builds in B16349: Diff 22351.Feb 12 2023, 7:01 PM

ashoat requested review of this revision.Feb 12 2023, 7:01 PM

atul accepted this revision.Feb 12 2023, 7:13 PM

This revision is now accepted and ready to land.Feb 12 2023, 7:13 PM

Closed by commit rCOMMc2af4d6d0486: Reimplement generateRandomString using browser crypto module (authored by ashoat). · Explain WhyFeb 12 2023, 8:05 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc2af4d6d0486: Reimplement generateRandomString using browser crypto module.

Revision Contents
Changeset List

Path

Size

web/

utils/

text-utils.js

9 lines

Diff 22381

View Options

web/utils/text-utils.js

	// @flow			// @flow

				import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
	import * as React from 'react';			import * as React from 'react';

	import { type ThreadInfo } from 'lib/types/thread-types';			import { type ThreadInfo } from 'lib/types/thread-types';

	import SWMansionIcon from '../SWMansionIcon.react';			import SWMansionIcon from '../SWMansionIcon.react';
				import ThreadMenuItem from './thread-menu-item.react';
	import css from './thread-menu.css';			import css from './thread-menu.css';

	type ThreadMenuProps = {			type ThreadMenuProps = {
	+threadInfo: ThreadInfo,			+threadInfo: ThreadInfo,
	};			};

	function ThreadMenu(props: ThreadMenuProps): React.Node {			function ThreadMenu(props: ThreadMenuProps): React.Node {
	const [isOpen, setIsOpen] = React.useState(false);			const [isOpen, setIsOpen] = React.useState(false);

	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	const { threadInfo } = props;			const { threadInfo } = props;

	const menuItems = [];			const menuItems = React.useMemo(() => {
				const settingsItem = (
				<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
				);
				const notificationsItem = (
				<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
				);
				const items = [settingsItem, notificationsItem];
				return items.filter(Boolean);
				}, []);

	const closeMenuCallback = React.useCallback(() => {			const closeMenuCallback = React.useCallback(() => {
	document.removeEventListener('click', closeMenuCallback);			document.removeEventListener('click', closeMenuCallback);
	if (isOpen) {			if (isOpen) {
	setIsOpen(false);			setIsOpen(false);
	}			}
	}, [isOpen]);			}, [isOpen]);

	Show All 34 Lines

Reimplement generateRandomString using browser crypto moduleClosedPublicActions