Page MenuHomePhabricator
Differential D6709

[lib][landing][web] Update to style-loader@3.3.1
ClosedPublic
Actions

Authored by ashoat on Feb 12 2023, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 4:09 PM
Unknown Object (File)
Wed, Mar 26, 11:11 AM
Unknown Object (File)
Thu, Mar 13, 2:06 PM
Unknown Object (File)
Mar 2 2025, 8:02 PM
Unknown Object (File)
Mar 2 2025, 8:02 PM
Unknown Object (File)
Mar 2 2025, 8:00 PM
Unknown Object (File)
Mar 2 2025, 7:40 PM
Unknown Object (File)
Feb 21 2025, 2:43 PM
View All Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMM8b0ab6191fff: [lib][landing][web] Update to style-loader@3.3.1
Summary

After updating to Webpack 5, I figured I'd update this related package as well.

Depends on D6708

Test Plan
  1. I tested dev build in landing and web (we only use this plugin in dev builds) via yarn dev in landing + web + keyserver and then tested the website
  2. I reviewed the releases on GitHub and found two versions with breaking changes listed: 2.0.0 and 3.0.0 Neither seemed to mentioned anything relevant to us

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
landing/
1 line
lib/
1 line
webpack/
3 lines
web/
1 line
22 lines

Diff 22408

View Options

landing/package.json

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

lib/package.json

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

lib/webpack/shared.cjs

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

web/package.json

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

yarn.lock

Loading...